search

hipay / hipay-fullservice-sdk-magento2

Official repository of the HiPay Fullservice extension for Magento v2.
https://developer.hipay.com/doc/hipay-fullservice-sdk-magento2/
Apache License 2.0
10 stars 16 forks source link

Magento JS minification corrupts output files due to comments #126

Closed ebaschiera closed 4 years ago

ebaschiera commented 4 years ago

Hello, on a Magento 2.1.8 if I turn on JS minification in Backend (Stores -> Configuration -> Advanced -> developer -> Minify JavaScript Files) I get errors at checkout and the page breaks.

It looks like the problem is a comment in several js files like this: https://github.com/hipay/hipay-fullservice-sdk-magento2/blob/1.9.0/view/frontend/web/js/view/payment/method-renderer/hipay-banco.js#L21

The comment //@override hipay-hosted confuses the minifier and the output is a one-liner that is almost all commented out.

Removing those comments fixes the issue.

Thanks!

ebaschiera commented 4 years ago

I noticed it's fixed on https://github.com/hipay/hipay-fullservice-sdk-magento2/releases/tag/1.9.1 Thanks!