search

hipay / hipay-fullservice-sdk-magento2

Official repository of the HiPay Fullservice extension for Magento v2.
https://developer.hipay.com/doc/hipay-fullservice-sdk-magento2/
Apache License 2.0
10 stars 16 forks source link

Bad constantes in di.xml #147

Closed AgenceTBD closed 2 years ago

AgenceTBD commented 2 years ago

Updating module via composer, last version 1.14.1 have bad constant defined in the di.xml file.

This is the list : vendor/hipay/hipay-fullservice-sdk-magento2/etc/frontend/di.xml:34: HiPay\FullserviceMagento\Model\Method\MbwayHostedFields::HIPAY_METHOD_CODE vendor/hipay/hipay-fullservice-sdk-magento2/etc/frontend/di.xml:108: HiPay\FullserviceMagento\Model\Method\MbwayHostedFields::HIPAY_METHOD_CODE vendor/hipay/hipay-fullservice-sdk-magento2/etc/frontend/di.xml:34: HiPay\FullserviceMagento\Model\Method\MultibancoHostedFields::HIPAY_METHOD_CODE vendor/hipay/hipay-fullservice-sdk-magento2/etc/frontend/di.xml:127: HiPay\FullserviceMagento\Model\Method\MultibancoHostedFields::HIPAY_METHOD_CODE

Classes MbwayHostedFields and MultibancoHostedFields does not exist.

I make a PR

legithubdeaymeric commented 2 years ago

Hi @AgenceTBD

I don't understand:

https://github.com/hipay/hipay-fullservice-sdk-magento2/blob/master/Model/Method/MultibancoHostedFields.php

AgenceTBD commented 2 years ago

Okay... I see the miss... Sorry for the issues, when getting update we have all files ok, but sending them over client repository the were missing. My bad, thans for your return. I close them.