hipay / hipay-fullservice-sdk-magento2

Official repository of the HiPay Fullservice extension for Magento v2.
https://developer.hipay.com/doc/hipay-fullservice-sdk-magento2/
Apache License 2.0
10 stars 16 forks source link

Order cancel create two reservations on inventory_reservation table with MSI #161

Closed syno-bgt closed 4 months ago

syno-bgt commented 12 months ago

Hi,

I saw the issue when i had difference between qty and salable_qty on my product

To reproduce the issue, follow these steps :

To have a temporary fix, i just comment the line $order->cancel(); on the Cron/CleanPendingOrders.php file.

It is not a correct fix, it causes other issues but not important on my side.

Thank you.

JBaptisteLvt commented 11 months ago

Hello !

We are going to take a look at this. Thank you for your report !

JBaptisteLvt commented 11 months ago

Hello @syno-bgt !

I did kind of reproduce what you are saying, except the lines in inventory_reservation are cancelling each other : one has a positive quantity, and the other the negative quantity. I think this is magento's way to track reservation history. In our test environment, the qty and salable_qty are equal after order cancellation.

HiPay does not tinker directly with quantities or stock, we use Magento's functions to cancel or update orders. Maybe another module is interfering with this function ?

stormwind85 commented 4 months ago

Hi @syno-bgt

Sorry for not responding to you sooner.

But this issue is related to this closed one

We did a fix on our latest version 1.22.3 I hope it will resolve your problem with our new version.

Now, I will close this ticket to avoid duplicate issues. Thanks again !