search

hipay / hipay-fullservice-sdk-php

Official repository of the HiPay Fullservice SDK for PHP.
https://developer.hipay.com/doc/hipay-fullservice-sdk-php/
Apache License 2.0
12 stars 12 forks source link

bad value on personnal data #34

Closed tenev911 closed 6 years ago

tenev911 commented 6 years ago

Hi on this line https://github.com/hipay/hipay-fullservice-sdk-php/blob/3272b6cc82ff93c7fd7a94e0738f81e4a986b93b/lib/HiPay/Fullservice/Gateway/Mapper/PersonalInformationMapper.php#L45

$firstname = isset($source['firstname']) ?: null;

$firstname will be true instead of the firstname.

it must be:

$firstname = isset($source['firstname']) ? $source['firstname'] : null;

jprotin commented 6 years ago

Hi @tenev911

Thank you for your comment, we will fix very quickly.

jprotin commented 6 years ago

Hi Tonev911,

https://github.com/hipay/hipay-fullservice-sdk-php/pull/35

It's merged in develop and we will make a new release next week (22/03 or 23/03)

Many thanks !