search

hipchat / hipchat-rb

HipChat HTTP API Wrapper in Ruby with Capistrano hooks
https://www.hipchat.com/docs/apiv2
MIT License
336 stars 172 forks source link

Fix dependency issue that is breaking the Travis build #182

Closed gabrieldeal closed 7 years ago

gabrieldeal commented 7 years ago

Locking the versions of the addressable and json gems to the versions immediately before they stopped supporting Ruby 1.9.3.

This seems like a maintenance problem; should hichat-rb drop Ruby 1.9 support instead?

The Travis build error:

$ ruby --version ruby 1.9.3p551 (2014-11-13 revision 48407) [x86_64-linux] ... $ bundle install --jobs=3 --retry=3 Fetching gem metadata from https://rubygems.org/........... Fetching version metadata from https://rubygems.org/. Resolving dependencies... public_suffix-2.0.4 requires ruby version >= 2.0, which is incompatible with the current version, ruby 1.9.3p551

For example: https://travis-ci.org/hipchat/hipchat-rb/jobs/177747406

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 91d330cecea5f0d6da089dde3b84b326972c2cec on gabrielmdeal:dependency-fix into e65b02d966ebce30d0601a3235fa6e6e9cef3216 on hipchat:master.

rberrelleza commented 7 years ago

Thanks for the contribution!

rberrelleza commented 7 years ago

The support for ruby 1.9 has been a bit of a hot topic lately, it already caused to other breakages due to certain dependencies no longer working. It might be worth dropping support, maybe as part of a 'major' release of the gem (2.0). Please add your thoughts on https://github.com/hipchat/hipchat-rb/issues/183