search

hipchat / hipchat-rb

HipChat HTTP API Wrapper in Ruby with Capistrano hooks
https://www.hipchat.com/docs/apiv2
MIT License
336 stars 172 forks source link

Add User#update #187

Closed gabrieldeal closed 7 years ago

gabrieldeal commented 7 years ago

Add User#update method that supports the V1 and V2 API.

I tested V1 and V2 against a real HipChat server.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 599b279b779152fffc4b1039476fe8586fd3cf3e on gabrielmdeal:update-user3 into aeb06bc1c193a55368feac0a61dc80b3b06b6fff on hipchat:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 106b437027e9db43c208077b0de894da0fb2b86d on gabrielmdeal:update-user3 into aeb06bc1c193a55368feac0a61dc80b3b06b6fff on hipchat:master.

rberrelleza commented 7 years ago

I prefer the approach on https://github.com/hipchat/hipchat-rb/pull/181, since it's more explicit on what's going on, but this one supports v1 and v2, which is very nice. What do you think @gabrielmdeal @craig-gomes ?

gabrieldeal commented 7 years ago

@rberrelleza I'm happy to add more documentation to this PR or close this in favor of the other PR. No worries either way.

I should have more patience! I had given up on a reply on the other PR.

gabrieldeal commented 7 years ago

I'll close this since #181 is moving forward.