search

hipchat / hipchat-rb

HipChat HTTP API Wrapper in Ruby with Capistrano hooks
https://www.hipchat.com/docs/apiv2
MIT License
336 stars 172 forks source link

Support pagination for fetching users and rooms #201

Closed artfuldodger closed 7 years ago

artfuldodger commented 7 years ago

Enable pagination, without which it is impossible to get more than 100 rooms or users.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling e7eed9e99d373e53712cd05967a8e6e2be8196c5 on bonusly:support-pagination into 4a28188971a7eb481e3fe7a1162a992f1f99ef0f on hipchat:master.

rberrelleza commented 7 years ago

Thanks! Could you add a unit test for the room pagination use case?

artfuldodger commented 7 years ago

@rbergman Sure thing! Added a new commit with some specs.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 0053a11e00a117fd198dd93464366fa4816a3309 on bonusly:support-pagination into 4a28188971a7eb481e3fe7a1162a992f1f99ef0f on hipchat:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 73eeed423458c3ba1c26ebf135481f9835e335dd on bonusly:support-pagination into aaa9350929f739cecbc0e81901a5863f6dbba913 on hipchat:master.

artfuldodger commented 7 years ago

@rbergman Need anything from me here to help get this merged?

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 3c6f725b1de24b9b6358864958aab8b4822d5a32 on bonusly:support-pagination into 359bd59ca0b178df4f382a94f0fbfd0912c65c08 on hipchat:master.

rberrelleza commented 7 years ago

Thanks for your contribution!