Closed gheylen closed 9 years ago
-07T12:38:29.970215+00:00 heroku[hubotw.1]: Starting process with command bin/hubot --adapter hipchat --name Z --alias Z --disabled-httpd
2014-10-07T12:38:30.683387+00:00 heroku[hubotw.1]: State changed from starting to up
2014-10-07T12:38:33.248661+00:00 app[hubotw.1]: [Tue Oct 07 2014 14:38:33 GMT+0200 (CEST)] DEBUG Loading adapter hipchat
2014-10-07T12:38:34.050143+00:00 app[hubotw.1]: [Tue Oct 07 2014 14:38:34 GMT+0200 (CEST)] DEBUG OUT >
:+1: We noticed our bot in our rooms, but it won't respond to commands. We are running on Heroku.
Since when? Has it been working before?
@gheylen As of this morning.
Yes, also in my case. It's a Heroku problem?
Same Problem
Same issue. Hanging in rooms, but non responsive.
Seeing this in logs.
[Tue Oct 07 2014 14:31:12 GMT+0000 (UTC)] INFO Connecting HipChat adapter...
[Tue Oct 07 2014 14:31:13 GMT+0000 (UTC)] INFO Connected to hipchat.com as @Hubot
[Tue Oct 07 2014 14:31:14 GMT+0000 (UTC)] ERROR TypeError: Cannot call method 'getText' of undefined
at getText (/srv/hubot/shared/vendor/node_modules/hubot-hipchat/src/connector.coffee:508:3, <js>:467:31)
at getInt (/srv/hubot/shared/vendor/node_modules/hubot-hipchat/src/connector.coffee:511:3, <js>:471:21)
at rooms (/srv/hubot/shared/vendor/node_modules/hubot-hipchat/src/connector.coffee:149:29, <js>:131:31)
at Array.map (native)
at Connector.<anonymous> (/srv/hubot/shared/vendor/node_modules/hubot-hipchat/src/connector.coffee:140:9, <js>:121:73)
at Connector.g (events.js:175:14)
at Connector.EventEmitter.emit (events.js:98:17)
at Connector.onStanza (/srv/hubot/shared/vendor/node_modules/hubot-hipchat/src/connector.coffee:453:7, <js>:397:21)
at Client.EventEmitter.emit (events.js:95:17)
at Client.onStanza (/srv/hubot/shared/vendor/node_modules/hubot-hipchat/node_modules/node-xmpp/node_modules/node-xmpp-client/index.js:158:14)
at Connection.EventEmitter.emit (events.js:95:17)
at Connection.onStanza (/srv/hubot/shared/vendor/node_modules/hubot-hipchat/node_modules/node-xmpp/node_modules/node-xmpp-core/lib/connection.js:269:14)
at StreamParser.<anonymous> (/srv/hubot/shared/vendor/node_modules/hubot-hipchat/node_modules/node-xmpp/node_modules/node-xmpp-core/lib/connection.js:156:14)
at StreamParser.EventEmitter.emit (events.js:95:17)
at SaxExpat.<anonymous> (/srv/hubot/shared/vendor/node_modules/hubot-hipchat/node_modules/node-xmpp/node_modules/node-xmpp-core/lib/stream_parser.js:58:22)
at SaxExpat.EventEmitter.emit (events.js:95:17)
at [object Object].<anonymous> (/srv/hubot/shared/vendor/node_modules/hubot-hipchat/node_modules/node-xmpp/node_modules/node-xmpp-core/node_modules/ltx/lib/sax_expat.js:14:14)
at [object Object].EventEmitter.emit (events.js:95:17)
at [object Object].Parser.parse (/srv/hubot/shared/vendor/node_modules/hubot-hipchat/node_modules/node-xmpp/node_modules/node-xmpp-core/node_modules/ltx/node_modules/node-expat/lib/node-expat.js:18:22)
at SaxExpat.write (/srv/hubot/shared/vendor/node_modules/hubot-hipchat/node_modules/node-xmpp/node_modules/node-xmpp-core/node_modules/ltx/lib/sax_expat.js:24:22)
at StreamParser.write (/srv/hubot/shared/vendor/node_modules/hubot-hipchat/node_modules/node-xmpp/node_modules/node-xmpp-core/lib/stream_parser.js:102:21)
at Connection.onData (/srv/hubot/shared/vendor/node_modules/hubot-hipchat/node_modules/node-xmpp/node_modules/node-xmpp-core/lib/connection.js:208:21)
at CleartextStream.<anonymous> (/srv/hubot/shared/vendor/node_modules/hubot-hipchat/node_modules/node-xmpp/node_modules/node-xmpp-core/lib/connection.js:64:14)
at CleartextStream.EventEmitter.emit (events.js:117:20)
at CleartextStream.<anonymous> (_stream_readable.js:746:14)
at CleartextStream.EventEmitter.emit (events.js:92:17)
at emitReadable_ (_stream_readable.js:408:10)
at _stream_readable.js:401:7
at process._tickCallback (node.js:415:13)
Same error here. Running on heroku.
Just as a point for debugging - we're not using Heroku and have it self-hosted. Has been working fine for us this morning, so guessing this is not something on HipChat's end. Or at the very least, some strange combination of updates on both.
@joeellis I've tried running Hubot locally and connecting to HipChat. I'm getting the same error as on Heroku.
@kb I actually don't get such errors. Everything seems to be fine, reading the logs. Though, the bot is not answering anymore, nor joining the rooms it was joining yesterday. It just stands there. Appearing online, while the HipChat user admin page doesn't even pick up the bot being online.
Read through the other issues and I'm experiencing this exact problem https://github.com/hipchat/hubot-hipchat/issues/203
We're seeing the same thing, we can list the rooms to join using the environment variable and then it joins them fine, but if we ask Hubot to join all rooms, it doesn't. We're not hosted by Heroku.
Maybe Hipchat have changed their API subtly?
If you have HUBOT_HIPCHAT_ROOMS
set to @all
, the bot joins, but fails silently. Try connecting without having the HUBOT_HIPCHAT_ROOMS
environment variable set, and it will fail with the getText
error.
Same issue here, since a few hours ago. We're on Heroku as well.
We were not receiving any error message. I upgraded to the latest hubot-hipchat and hubot releases, and I confirm the same error
2014-10-07T14:48:10.305172+00:00 app[web.1]: [Tue Oct 07 2014 14:48:10 GMT+0000 (UTC)] ERROR TypeError: Cannot call method 'getText' of undefined
2014-10-07T14:48:10.305188+00:00 app[web.1]: at Connector.emit (events.js:98:17)
2014-10-07T14:48:10.305184+00:00 app[web.1]: at Array.map (native)
2014-10-07T14:48:10.305203+00:00 app[web.1]: at SaxExpat.emit (events.js:95:17)
2014-10-07T14:48:10.305204+00:00 app[web.1]: at [object Object].<anonymous> (/app/node_modules/hubot-hipchat/node_modules/node-xmpp/node_modules/node-xmpp-core/node_modules/ltx/lib/sax_expat.js:14:14)
2014-10-07T14:48:10.305191+00:00 app[web.1]: at Client.emit (events.js:95:17)
Just tested the fix in #203 and as mentioned above, that does indeed fix the issue. Thanks!
The fix in #203 is working for me as well on Heroku.
I was seeing the same problem. Atlassian says they had an outage but it should be fixed now https://twitter.com/HipChat/status/519512361582223361
Hubot is working for me again on heroku even without the patch in https://github.com/hipchat/hubot-hipchat/issues/203
They rolled out their changes. It was not related to the outage. https://twitter.com/HipChat/status/519514806345551872
I'm still facing this issue.
Now it's works. I restart the bot with the heroku restart command
I'm still facing this issue - specifically @gheylen 's, not the TypeError
which seems like it might be different. Was there any resolution on this?
The bot will reply to PMs, and will join rooms when invited. But it won't reply to messages in rooms.
Also, here's the relevant part of my package.json. It comes from a fresh install of hubot/hubot-hipchat today:
"dependencies": {
"githubot": "^1.0.0-beta2",
"hubot": "^2.9.3",
"hubot-diagnostics": "0.0.1",
"hubot-google-images": "^0.1.0",
"hubot-google-translate": "^0.1.0",
"hubot-help": "^0.1.1",
"hubot-heroku-keepalive": "0.0.4",
"hubot-hipchat": "^2.7.5",
"hubot-pugme": "^0.1.0",
"hubot-redis-brain": "0.0.2",
"hubot-rules": "^0.1.0",
"hubot-shipit": "^0.1.1",
"hubot-youtube": "^0.1.2",
"pypi": "^0.1.2",
"xml2js": "^0.4.4"
},
"engines": {
"node": "0.10.x"
}
@ysimonson, I believe this was a bug on hipchat's end that was fixed by them.
We're currently using this fork and not facing any issues: "hubot-hipchat": "git://github.com/cheif/hubot-hipchat.git", (replace your hubot-hipchat line with this to use it)
You can try using this fork to see if it works fine. If it does, then hipchat's api might have changed again.
I tried the fork and it didn't fix anything. Allegedly it's for the TypeError
.
With debug mode, here's the output when receiving a PM:
[Fri Oct 31 2014 14:57:31 GMT-0400 (EDT)] DEBUG Message 'musebot: ping' matched regex //^\s*[@]?musebot[:,]?\s*(?:PING$)/i/
[Fri Oct 31 2014 14:57:31 GMT-0400 (EDT)] DEBUG OUT > <message to="XXX@chat.hipchat.com" type="chat" from="XXX@chat.hipchat.com/hubot-hipchat"><inactive xmlns="http://jabber/protocol/chatstates"/><body>PONG</body></message>
Here's the output when receiving a chat message:
[Fri Oct 31 2014 14:57:51 GMT-0400 (EDT)] DEBUG Message 'musebot ping' matched regex //^\s*[@]?musebot[:,]?\s*(?:PING$)/i/
[Fri Oct 31 2014 14:57:51 GMT-0400 (EDT)] DEBUG OUT > <message to="XXX@conf.hipchat.com" type="chat" from="XXX@chat.hipchat.com/hubot-hipchat"><inactive xmlns="http://jabber/protocol/chatstates"/><body>PONG</body></message>
[Fri Oct 31 2014 14:57:52 GMT-0400 (EDT)] DEBUG OUT > <r/>
(Scrubbed the JIDs in case they're supposed to be private.) So it appears that it's receiving messages fine and sending something back, but it only works for PMing. I don't know jabber, but both messages look legit from what I'd guess.
hmm. Does the bot have permissions to these chat rooms? Can you try creating a new room and inviting the bot there?
This is with a brand new room, and I invited it in. It can join the room fine after receiving an invite, so permissions shouldn't be an issue unless I'm missing something here.
Okay, then I'm not sure what's going on here. Sorry :(
It's cool, thanks @surajreddy
If you are using a self hosted version of hipchat be sure to
$ export HUBOT_HIPCHAT_XMPP_DOMAIN=btf.hipchat.com
OP's issue appeared to be a dup of #203. Any other issues discussed here that are still a problem after adopting the latest npm publish should create a new issue.
Today, when I came in, I noticed that our bot appeared online in the lobby, but not appearing online in any of the rooms it should be in. Also, the Group Admin pages of HipChat show that the user which the bot uses to connect to HipChat hasn't been connected since yesterday.
This is rather strange. It is connected, because we get a green circle in the lobby, but it doesn't show on the admin pages of HipChat. Also, it doesn't answer.
Another strange thing is that it does respond when you spam "help" during its startup. After that it just goes silent again. How can it respond on HipChat and not have itself logged as "logged in" @ hipchat admin pages? oO
Anyone else having problems? I haven't touched the bot, its config, or its environment for a while. Suddenly it stopped working. So naturally I thought about changes on the HipChat side, or the Heroku side. Which means other people should also have problems?
Thanks for feedback.