hipchat / hubot-hipchat

HipChat adapter for GitHub's Hubot
https://www.hipchat.com/help/page/bots
MIT License
666 stars 252 forks source link

BOSH server was not actually passed to the connector #260

Closed NightWhistler closed 8 years ago

NightWhistler commented 9 years ago

Change-Id: Ieabd0efd73d14e313ccdb2e0b05e0bfb10dca6b2

A user can specifiy a BOSH server to be used by setting the HUBOT_HIPCHAT_BOSH_URL environment variable.

This caused the URL to be printed in debug output, but it was not actually passed to the connector or the underlying client. Because of this it was never actually attempted to connect through BOSH, but instead the plain XMPP connection on port 5222 was used.