search

hipchat / hubot-hipchat

HipChat adapter for GitHub's Hubot
https://www.hipchat.com/help/page/bots
MIT License
666 stars 252 forks source link

removing circular loop on disconnect/offline causing stack overflow. #267

Closed aaronblythe closed 8 years ago

aaronblythe commented 8 years ago

For Issue #255.

TheFynx commented 8 years ago

:+1:

DavidR91 commented 8 years ago

Is this ever going to be merged? The issue this is fixing makes this adapter basically unusable as it stands

(any minor connection hiccup and hubot is dropped into an infinite spiral of console errors. It doesn't even exit meaning that we can't even auto-restart it)

TheFynx commented 8 years ago

@DavidR91 for now we are having to specifically install via npm install git://github.com/hipchat/hubot-hipchat#1dbf8d4e911673d2ec566452f4b1fc1e15b7edd4 --save

Been going for about 2 weeks now without any disconnect issues.