search

hipchat / hubot-hipchat

HipChat adapter for GitHub's Hubot
https://www.hipchat.com/help/page/bots
MIT License
666 stars 252 forks source link

Fix the processing of rooms. #280

Closed 178inaba closed 4 years ago

178inaba commented 8 years ago

Can get the name of the after the rename. msg.message.room

messageRoom was also to make it work.

Help specifies the private room in the user's name. https://github.com/hubot-scripts/hubot-help/blob/master/src/help.coffee#L76

Hubot user have only the name. https://github.com/github/hubot/blob/master/src/user.coffee#L9

So I get the JID from the name.

@rbergman I'd like a merge and npm release!

rbergman commented 8 years ago

My ability to actively maintain this is practically nil now. If someone wants to fork this repo, curate the open PRs by merging and manually testing them in a production Hubot so we can be sure they're well vetted, I'd be happy to accept aggregate PRs here and publish to npm. I don't have an effective way to test on a production Hubot any more with the (lack of) time I have available for side projects, unfortunately.

178inaba commented 8 years ago

@rbergman Thanks for the reply! I do not even have time to test the other pull request. But, I have tested this pull request by production Hubot.

Test was carried out by editing the package.json as follows:

{
  ...
  "dependencies": {
    ...
    "hubot-hipchat": "178inaba/hubot-hipchat#rooms",
    ...
  },
  ...
}

I was sure that my pull request is not a problem.

Wilfred commented 6 years ago

@rbergman there's a great PR at #303 that does exactly that: it's merged the PRs, tested them against a production instance and proposed a new release. Would you be able to merge them and/or give @benhanzl commit powers?