hipchat / hubot-hipchat

HipChat adapter for GitHub's Hubot
https://www.hipchat.com/help/page/bots
MIT License
666 stars 252 forks source link

Exceeding message size limit fails silently #289

Closed njam closed 3 years ago

njam commented 7 years ago

When sending a message with a size of approximately 40kb or greater the message is not delivered. There's not error about that from hubot-hipchat.

Reproduce with this:

module.exports = function(robot) {
  return robot.catchAll(function(chat) {
    chat.send('x'.repeat(40000));
  });
};

Do we receive something back from the server from which we can identify this case? Or should we detect it in hubot-hipchat?

yixiaol-m commented 7 years ago

+1 for the issue. Possible cause: hipchat api has a message body length limit: 1 - 10000 https://www.hipchat.com/docs/apiv2/method/send_room_notification

njam commented 3 years ago

too old