hipchat / hubot-hipchat

HipChat adapter for GitHub's Hubot
https://www.hipchat.com/help/page/bots
MIT License
666 stars 252 forks source link

2.13.0 #303

Closed benhanzl closed 6 years ago

benhanzl commented 6 years ago

Fixes #272 #273 #277 #278.

Proposed Changes

I have merged a few of the outstanding pull requests and propose creating the 2.13.0 release with them. I focused on the pull requests that did NOT introduce new features or were improvements that in my opinion needed some further discussion.

This release:

{
  "user": {
    "id": "123456",
    "jid": "123456_1234560@chat.hipchat.com",
    "name": "Ben Hanzl",
    "mention_name": "BenHanzl",
    "email_address": "benhanzl@testing.com",
    "room": "123456_testing@conf.hipchat.com"
  },
  "done": false,
  "room": "123456_testing@conf.hipchat.com",
  "text": "hello world"
}

Testing

I tested each of these code changes specifically on a production HipChat instance. I have also had this version deployed to our production instance for the past two weeks without issue.

Future

Once this is merged and published to npm, I will start the discussion with the other open pull requests to get them resolved.

benhanzl commented 6 years ago

@rbergman Let me know if there is anything I can do to assist with getting this merged.

liorbrauer commented 6 years ago

Great job @benhanzl on this PR! Only issue is that it seems to not be published on NPM yet 😢