hiposfer / hive

Your go-to routing app for public transport
GNU Lesser General Public License v3.0
10 stars 0 forks source link

integrate kamal directions - part 1 #104

Closed carocad closed 6 years ago

carocad commented 6 years ago

part of #74

This is by no means a complete integration. However, after trying to integrate it I realised that there are several pieces of information missing in kamal's response.

So for the time being I think it suffices to just review what I currently have and then work again on it once we change kamal.

CHANGES:

PS: I also did some small changes in the build script since it started failing for some reason. My guess is that the latest expo release broke it.

PS2: you will need a local kamal instance running for the app to be usable. You could also have a remote container running but right now is hardcoded to localhost

mehdisadeghi commented 6 years ago

:shipit: This branch has been deployed to: https://expo.io/@carocad/hive?release-channel=directions

Download the Expo app and scan this QR code to get started!

QR Code

mehdisadeghi commented 6 years ago

@carocad starting a local kamal did not change anything. The app runs, I see the new direction icons in the bottom but nothing else.

carocad commented 6 years ago

Unfortunately currently the http function that I use is configured to ignore errors, and I think the IP was hard coded to match my network so you need to change that :(

We need to change our error strategy in the app but since react native needs special handling for that I haven't implemented it

mehdisadeghi commented 6 years ago

:shipit: This branch has been deployed to: https://expo.io/@carocad/hive?release-channel=directions

Download the Expo app and scan this QR code to get started!

QR Code