search

hiposfer / hive

Your go-to routing app for public transport
GNU Lesser General Public License v3.0
10 stars 0 forks source link

consider removing http/json and using js/fetch native directly #110

Closed carocad closed 6 years ago

carocad commented 6 years ago

Initially I did this to avoid having to deal with Javascript promises which are not idiomatic in Clojurescript.

However it has become an unnecessary abstraction which doesnt expose the complete power of js/fetch.

I think it would be better to remove it and simply use tool/async or even extend work/transact to accept promises and use tool/async directly

carocad commented 6 years ago

this was already fixed in https://github.com/hiposfer/hive/commit/02a2ec1a04707bfc834d2757214552b9df35e5ed