search

hiposfer / hive

Your go-to routing app for public transport
GNU Lesser General Public License v3.0
10 stars 0 forks source link

remove unstable native-base dependency #73

Closed carocad closed 6 years ago

carocad commented 6 years ago

Currently I am hacking the node_modules dependencies to avoid the Feather.js not being found bug.

However this also means that every time a new dependency is added/removed the md5 hash of the dependency is corrupted or the bug appears again which is really hacky.

The problem is that expo provides some modules that are also provided by native base and at the same time, expo provides its own version of react-native which makes the dependency hell even worse to figure out.

I think the best way to solve this is simply to avoid having native-base as a dependency and instead use our own designs for the UI components thus avoiding the bug all together

carocad commented 6 years ago

@mehdisadeghi would you like to take care of this?

I think that this is what is causing your error. Unfortunately, as I mentioned, all the JS dependencies are so tangled together that I have just been working around the issue to be able to continue working in the app without losing too much time with refactoring.

mehdisadeghi commented 6 years ago

Let me see what I can do.

carocad commented 6 years ago

@mehdisadeghi taking into account how unstable things are at the moment, I think it would be best if I take care of this such that you can have a reproducible working environment to work with.

Otherwise it would be a battle uphill with no support, which is far from ideal.