search

hiposfer / hive

Your go-to routing app for public transport
GNU Lesser General Public License v3.0
10 stars 0 forks source link

WIP: Add expo PR preview apps. #94. #95

Closed mehdisadeghi closed 6 years ago

mehdisadeghi commented 6 years ago

@carocad have a look at travis logs. For any reason exp login fails.

carocad commented 6 years ago

@mehdisadeghi it seems this was a mere typo problem.

I changed your expo credentials by mine and it correctly logged in.

We have another problem now though. The build fails because we havent exposed the init.json to the app itself. I guess we would have to use something like env vars.

carocad commented 6 years ago

on another topic. Usually both exp and react native chock on the output from the clojurescript compiler.

It seems that those packagers were made with the assumption that they will have lots of little files which can be processed separatedly. Clojurescript on the other hand, creates a single minified file; which those packagers dont like.

That might become a problem for us as the app grows bigger

EDIT: I think there is a workaround but I dont remember it right now. I will ask in the # clsrn slack channel

carocad commented 6 years ago

@mehdisadeghi I think the init.json problem can be solved with env vars. But I wont be able to work on this now. Maybe tonight? not sure but it can be solve easily ;)

mehdisadeghi commented 6 years ago

@carocad sure. I'll work on it this evening.

mehdisadeghi commented 6 years ago

:shipit: This branch has been deployed to: https://expo.io/@carocad/hive?release-channel=expo-ci

Download the Expo app and scan this QR code to get started!

QR Code

mehdisadeghi commented 6 years ago

@carocad Wow! It's working!

carocad commented 6 years ago

@mehdisadeghi sorry it was my fault that appr was not working. I had switched in travis to build on every push instead of on pull request.

However, there is no space for comments if you just push to a branch. It has to be on pull request :D

Now it works !!! 🚀

mehdisadeghi commented 6 years ago

Apparently there is a env problem. When I scan the above app I get an error which complains that MAPBOX and AUTH0 env vars are missing. Shall we set them in travis?

carocad commented 6 years ago

@mehdisadeghi I just did :)

mehdisadeghi commented 6 years ago

I triggered a new build, we'll see in a few minutes :)

mehdisadeghi commented 6 years ago

:shipit: This branch has been deployed to: https://expo.io/@carocad/hive?release-channel=expo-ci

Download the Expo app and scan this QR code to get started!

QR Code

mehdisadeghi commented 6 years ago

:shipit: This branch has been deployed to: https://expo.io/@carocad/hive?release-channel=expo-ci

Download the Expo app and scan this QR code to get started!

QR Code

mehdisadeghi commented 6 years ago

:shipit: This branch has been deployed to: https://expo.io/@carocad/hive?release-channel=expo-ci

Download the Expo app and scan this QR code to get started!

QR Code

mehdisadeghi commented 6 years ago

@carocad congrats! :)

carocad commented 6 years ago

@mehdisadeghi to you too :)