search

hiposfer / o2g

A simple tool to extract GTFS feed from OpenStreetMap.
https://o2g.herokuapp.com/
MIT License
11 stars 2 forks source link

unique timezone for multiple agencies #28

Open mehdisadeghi opened 6 years ago

mehdisadeghi commented 6 years ago

GTFS document states:

If multiple agencies are specified in the feed, each must have the same agency_timezone.

Does this mean that we can't produce GTFS feeds for regions stretching over multiple time zones?

carocad commented 6 years ago

@mehdisadeghi I would guess that our smart calculations are an over-engineered solution 😆. I guess we could simply check the timezone of the geometric middle point of the region.

Based on the GTFS description I would say that this restricts GTFS files to a country as maximum region; although multi-timezones countries would be problematic. Maybe a bug in the definition? or is there a technical aspect that we are forgetting?

mehdisadeghi commented 6 years ago

we could simply check the timezone of the geometric middle point of the region.

That sounds like a good idea!

Maybe a bug in the definition? or is there a technical aspect that we are forgetting?

The best way to find out this would be checking some existing feeds.

mehdisadeghi commented 6 years ago

we could simply check the timezone of the geometric middle point of the region.

@carocad what about explicitly asking for the timezone instead of guesswork?

carocad commented 6 years ago

Good idea

However I would still make that optional. The user should be able to choose the Timezone but if not provided we would just go with our best guest