search

hiposfer / o2g

A simple tool to extract GTFS feed from OpenStreetMap.
https://o2g.herokuapp.com/
MIT License
11 stars 2 forks source link

fix validation of dummy gtfs generation #37

Closed carocad closed 6 years ago

carocad commented 6 years ago

With the latest fixes a new set of bugs appeared on the feed validation :(

Here is the output from the Saarland export FeedValidator: tmp.zip

mehdisadeghi commented 6 years ago

The validation should be part of tests. I'll update soon.

mehdisadeghi commented 6 years ago

@carocad Please see fix-validation branch. Still in progress but it addresses all the errors and only there remains the warnings.

mehdisadeghi commented 6 years ago

BTW, the file you've uploaded is broken.

carocad commented 6 years ago

BTW, the file you've uploaded is broken.

Thanks for the info. I will download the saarland file again and update it 😉

carocad commented 6 years ago

@mehdisadeghi I remembered that we had discussed about the 24hours things in the trips as well as other validation issues and after checking I found out that in fact you already took care of it on this branch: https://github.com/hiposfer/osmtogtfs/commit/710a08f89ebf87b3b4cf0015a2fa45ce7f09916e

It turns out that those changes were never merged which would explain why we are facing the same issues :(

mehdisadeghi commented 6 years ago

I found out that in fact you already took care of it on this branch: 710a08f

@carocad I have completely repeated myself :/

mehdisadeghi commented 6 years ago

Honestly I don't remember why I have merged the changes to the badge branch instead of master. Sorry about that.

mehdisadeghi commented 6 years ago

I'm deleting the badge branch after inspecting its commits. I copied some of them into a new commit and the rest is simply out of date.

mehdisadeghi commented 6 years ago

Done in #39