hippich / Bitcoin-Poker-Room

Sources for Bitcoin Poker Room.
http://betco.in
Other
132 stars 90 forks source link

Tourney should start when players_min reached, not players_quota #112

Open hippich opened 12 years ago

gg commented 12 years ago

MTTs are started when at least players_min players are registered. SNGs require players_quota players to be registered.

See pokerengine/pokertournament.py:

def canRun(self):
    if self.start_time < tournament_seconds():
        if self.sit_n_go == 'y' and self.registered >= self.players_quota:
            return True
        elif self.sit_n_go == 'n':
            if self.registered >= self.players_min:
                return True
            else:
                return None
        else:
            return False
    else:
        return False

I tested this locally with bots and the MTT ran when players_min was met.

hippich commented 12 years ago

any objections for SNGs follow same algorithm? I am not quite sure why SNG have it differently.

gg commented 12 years ago

On all poker sites I've played at, SNGs require a specific number of players to be registered. IMO, players want to know that they are going to be playing a SNG with exactly N players, than with X to Y players. One reason is strategic. For example, the strategy used when playing a 6-player SNG is typically different than a strategy used when playing a 9-player SNG.

On Sun, Aug 14, 2011 at 16:53, hippich reply@reply.github.com wrote:

any objections for SNGs follow same algorithm? I am not quite sure why SNG have it differently.

Reply to this email directly or view it on GitHub: https://github.com/hippich/Bitcoin-Poker-Room/issues/112#issuecomment-1803532