hippke / tls

Transit Least Squares: An optimized transit-fitting algorithm to search for periodic transits of small planets
MIT License
48 stars 25 forks source link

catalog_info_ returning the errors for radius/mass_min/max instead of the min/max values #100

Closed PS-OnGit closed 2 years ago

PS-OnGit commented 2 years ago

Dear TLS team, I noticed, that the catalog_info_TIC function returns the error values for the radius_min,radius_max,mass_min and mass_max.

This issue can be easily fixed, by changing lines 77 to 81 in catalog.py as follows:

radius_max = radius + result[0][71]
radius_min = radius - result[0][71]
mass = result[0][72]
mass_max = mass + result[0][73]
mass_min = mass - result[0][73]

The same is true for the catalog_info_EPIC and KIC, while there the _max and _min correspond to the asymmetric errors. Hence lines 27-31 and 56-60 should be:

radius_max = radius + result[0][3]
radius_min = radius - result[0][4]
mass = result[0][5]
mass_max = mass + result[0][6]
mass_min = mass - result[0][7]

I hope, that i don't misunderstood these queries.

Kind regards, Paul Schwarz

PS-OnGit commented 2 years ago

I just noticed my mistake, and have to correct my report.

The return values work as intended and as described in the documentation. but the naming is misleading. Please excuse my mistake!

Kind regards, Paul Schwarz