search

hippojay / script.plexbmc.helper

PleXBMC Client Remote Helper
33 stars 30 forks source link

Player name wrong #11

Open martink2 opened 9 years ago

martink2 commented 9 years ago

Hi,

i am running the helper in the latest release v.3.4.2 and it always reports the player with the name "kodi" instead of the name set in the settings, using the machine name ("PleXBMC") instead also has no effect.

Logs:

23:13:45 T:140541765334784  NOTICE: PlexGDM: Sending registration data: HTTP/1.0 200 OK
                                            Content-Type: plex/media-player
                                            Resource-Identifier: ab24658e-b31a-475f-b9ef-4f506301c7ae
                                            Name: kodi
                                            Port: 3005
                                            Product: PleXBMC
                                            Version: 3.6.1
                                            Protocol: plex
                                            Protocol-Version: 1
                                            Protocol-Capabilities: navigation,playback,timeline
                                            Device-Class: HTPC

Thanks for the help on this, not beeing able to set the player name makes it kind of difficult to control multiple installations in one network.

Martin

hippojay commented 9 years ago

martink2 - Thanks - i'll have a look.

@wickning1 - I'm looking at merging helper code into plexbmc so we have a single package to maintain. Helper will still run as a service, and initially I wo;t be making any changes, but I would like update to continue on the plexbmc repo. Doing this means we can reuse code from both, move functions from plexbmc to helper and avoid issues like these from arising. Is this ok with you - I think you have write access into plexbmc (if not, i can update).

hippojay commented 9 years ago

@austin1howard adding to conversation.

wickning1 commented 9 years ago

This problem is fixed in 3.4.7 but I didn't make a release out of it yet.

Merging sounds fine to me if Kodi allows it. My understanding was that it had to be a separate service addon in order to run at startup.

hippojay commented 9 years ago

I don't think that's the case any more. I was looking and the emby addon has a server+plugin architecture. I'll run a PoC first, but it looks like it's possible.

hippojay commented 9 years ago

PoC running fine with both functions in a single install. Showed up on my ios and I was able to remotely start a playback. Probably just need to add some logic and a check for existing helper installations (and notification or disabling). but apart from that it should work.

I'll push my test branch to github now if you want to have a quick look.