hippospace / aptos-wallet-adapter

Other
93 stars 96 forks source link

Fix for Petra emitting the public key instead of address #97

Closed kent-white closed 1 year ago

kent-white commented 1 year ago

Other wallets are emitting the address, this is confusing for dapps.

I'm ok with just emitting the address but seems to be a mismatch with what the interface expects. Might want to update the interface there - https://github.com/hippospace/aptos-wallet-adapter/blob/30258e351c304408cc52c0371f36a952b2ac4aed/packages/aptos-wallet-adapter/src/WalletAdapters/BaseAdapter.ts#L24

The base adapter expects the public key to be emitted.