hippware / rn-chat

MIT License

5 stars 0 forks source link

Relative to Production, "Take Photo" quality is extremely low on Experimental #1025

Closed zavreb closed 7 years ago

zavreb commented 7 years ago

Issue: Relative to prod, "Take Photo" quality is extremely low on Experimental. (Please note: all photos were taken on the same device) does anyone understand why? is it the cropper?

Expected Result:

Should at least have the same "Take Photo" quality as Product
Photo should sit below the header

1. Experimental: Photo Taken on Experimental to be Cover Photo

Experimental: Photo Used as Cover Photo on Experimental

Experimental: Photo Taken and Uploaded to Photo Carousel

Production: Photo Taken and Uploaded on Photo Carousel

High quality is maintained and image fits within viewport horizontally

zavreb commented 7 years ago

Image Taken:

Vs. Image Saved:

mstidham commented 7 years ago

Take Photo comparison

aksonov commented 7 years ago

Could it be related that Eric changed "Take Photo" to image cropper module?

southerneer commented 7 years ago

@rz on the OP, what is meant by "Photo should sit below the header"

zavreb commented 7 years ago

There seems to be padding from the header. From where the image sits below the header instead of right below it. I'll show you an example.

On Jul 26, 2017, at 16:45, Eric Kirkham notifications@github.com wrote:

@rz on the OP, what is meant by "Photo should sit below the header"

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

southerneer commented 7 years ago

Bumped up default image quality. Also fixed a bug @zavreb just discovered where images taken from PhotoGrid view weren't published.

@zavreb @mstidham cp'd to -eric

mstidham commented 7 years ago

Codepush Verified Staging Quality looks better to me.

zavreb commented 7 years ago

Quality is Great! Just needs to save now...at least for me

I'm having issues uploading images, however the quality of image rendered on cover photo and in carousel is MUCH better. however, it's just not saving.

Image Taken Missing

Take Image Shows after kill/reload, then disappears again

Spinning circle of doom

zavreb commented 7 years ago

Update: Played with it some more, it does seem to be saving over time, it's just hard to tell via the Client bc the spinners lingers (doesn't stop until i kill and reload) and for the photo grid, take photo images disappear. cc: @mstidham

southerneer commented 7 years ago

@zavreb sounds like a separate ticket since the quality issue is resolved.

zavreb commented 7 years ago

@southerneer played with it some more, can't reproduce now.

zavreb commented 7 years ago

Verified on Staging. Pushing ticket to "Verify on Prod"

mstidham commented 7 years ago

Verified on Prod

zavreb commented 7 years ago

Verified on Prod. Closing ticket.