search

hippware / rn-chat

MIT License
5 stars 0 forks source link

"Here" missing on widget (You're Here) #2933

Closed mstidham closed 5 years ago

mstidham commented 5 years ago

"Here" missing on widget (You're Here)

QA TEMPLATE Input
Device Type: iPhone 8 Plus
iOS: 12.0
tr Version: 3.7.0
Environment Staging
Codepush: 2534: attribution screen
Internet Connection Type: WiFi
Users affected? Miranda
User handle: @miranda
Bypass handle?: @testytester (191-9191)
Location access type? Always
Does this issue occur on other environments?
Time issue occurred (UTC)

Observed Result:

If testytester deletes a location from the widget when they return to the HS they are missing "Here" on the widget locations. You may have to delete more than 1 bot to reproduce this.

Expected Result:

User should see "You're Here"

Steps to reproduce:

  1. Tap on location from the widget (created by testytester)
  2. Tap Ellipsis
  3. Tap Delete
  4. Tap back caret
  5. Widget only shows "You're"

    Related Screenshots/Video Links:

    https://app.box.com/s/pyrd495omv4cwj0w84h1podq6k5ylq92

thescurry commented 5 years ago

Nothing I do... can recreate this, but @mstidham can recreate it easily. Maybe we should consider how this might be happening? Is the "here" getting cropped out possibly? Is "You're" and "Here" two different assets?

aksonov commented 5 years ago

We are using full text together "`You're\r\nHere`}", maybe it is the reason of cropping for different devices (i.e. 'Here' could be displayed but lower)

aksonov commented 5 years ago

@mstidham Please check my latest codepush and try to reproduce

mstidham commented 5 years ago

I was able to reproduce it on codepush #2933 with bypass account @testytester (191-9191) Steps:

  1. Create a location
  2. Return to the HS and the "Here" will be missing img_7891
aksonov commented 5 years ago

I cannot reproduce with these steps...

aksonov commented 5 years ago

@mstidham Looks like I even see part of "H" letter on your screenshot, weird..

mstidham commented 5 years ago

Video: https://app.box.com/s/f0brvv57y8pfccx6xn1iajlzvl6dpjgy

  1. I long press to create location
  2. Tap Next
  3. Add emoji
  4. Add title
  5. Pin Location
  6. Skip (share flow)
  7. Return to the HS
aksonov commented 5 years ago

I still cannot reproduce and even don't have any idea how it could happen. It looks like internal react native/animation issue. I propose to revisit this ticket after RN0.57 or RN0.58 migration is done.

thescurry commented 5 years ago

I'm seeing this more and more often... but I am also open to the idea that it's an internal react-native issue and happy to wait for RN0.58

bengtan commented 5 years ago

@mstidham, @thescurry:

A fix for this was recently submitted and merged. Hence it's waiting for deployment but on the 4.0.x (Staging/next) branch.

If desired ...

If this bug is still reproducible on either Staging 3.x.x or Prod, I can back-port the fix to those branches. Then QA can test in the bug's original habitat.

mstidham commented 5 years ago

I'm still able to reproduce this issue on 4.0.2 Steps:

  1. Open app
  2. Tap "You" card
  3. Tap Edit Profile
  4. Tap back caret twice

This is not consistent when producing with the above steps but has happened 2 out of 3 times.

image

thescurry commented 5 years ago

Are there two separate images for "You're" and "Here"? Can this just be one image, so we can increase the chances of this not happening? Are there some alternative solutions to solving this? It's not a big problem, but it's a problem that has persisted for way too long.

aksonov commented 5 years ago

@thescurry The app doesn't use images but text, that is why it is very very weird issue probably connected with some react native internals. It could be fixed after upgrading to latest react native version (0.58 will come soon), but could be not.

Probably it is better just to use one image for this text and fix it now. @irfirl could you prepare such image?

irfirl commented 5 years ago

@aksonov https://zpl.io/2EjErkD has the "You're here" image

aksonov commented 5 years ago

Great, could you implement it?

On 21 Jan 2019, at 19:48, Alan Qiu notifications@github.com wrote:

@aksonov https://zpl.io/2EjErkD has the "You're here"

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

thescurry commented 5 years ago

Thanks for looking into this guys. @irfirl @aksonov I'll leave it up to you to guys to decide the route we take on fixing this issue. It's something we should fix ahead of our live location/android release, so it's not a high priority, but let's make sure we get it sorted in the next month or two.

(cc: @bengtan)

mstidham commented 5 years ago

Codepush Verified: Staging-Eric

mstidham commented 5 years ago

Verified on Staging Version: 4.0.3

bengtan commented 5 years ago

@mstidham: This ticket is client-side only. If it works on Staging, it's likely to be good enough.

mstidham commented 5 years ago

Verified on 4.14.0 closing ticket.