search

hippware / rn-chat

MIT License
5 stars 0 forks source link

Unfriend/block should remove user from Sharing your live location screen #3882

Open mstidham opened 5 years ago

mstidham commented 5 years ago

Unfriend/block should remove user from "Sharing your live location screen

QA TEMPLATE Input
Device Type: iPhone 7 Plus
iOS: 12.3.1
tr Version: 4.15.0
Environment Prod
Codepush:
Internet Connection Type: WiFi
Users affected? Miranda
User handle: @miranda
Bypass handle?:
Location access type? Always
Does this issue occur on other environments?
Time issue occurred (UTC)

Observed Result:

User Firebasetest (650-555-0006) shared live location with user @miranda. @miranda unfriended user Firebasetest. @miranda remained on the "Sharing your live location" screen. User was no longer actually sharing live location it was only on this one screen.

Expected Result:

If user is unfriended/blocked a user they are sharing live location with it should remove them from the "Sharing your live location"

Steps to reproduce:

  1. Share live location with a user
  2. User unfriends the sharing user
  3. Sharing user still shows them on the list

    Related Screenshots/Video Links:

    image

bengtan commented 5 years ago

Notes to self:

  1. Users A and B are friends. User A is sharing LL to B.
  2. B has a location_share(other_user_id: A) notification.

If unfriend (from either user) happens, then:

  1. B has a location_share_end(other_user_id: A) notification.

However, the sharer user (ie. A) does not get a notification that the location share has ended. Even if the unfriend was initiated by B.

bengtan commented 5 years ago

Waiting for some server side changes:

location_share_end discussion hippware/wocky#2821

and then a subsequent client side change/fix.

bengtan commented 5 years ago

Note to self: Do #3882 and #4021 together.