search

hippware / rn-chat

MIT License
5 stars 0 forks source link

[dev] Discussion: Try out Hermes Javascript engine #3909

Open southerneer opened 5 years ago

southerneer commented 5 years ago

https://facebook.github.io/react-native/docs/hermes

RN 0.60.2 upgrade must happen first.

bengtan commented 5 years ago

RN 0.60.5 has been updated. Do we want to try this out?

southerneer commented 5 years ago

Let's do it! We played with this a little bit at the performance workshop at the RN EU conference and demo'd the faster startup time and tti (time to interactivity) with Hermes.

southerneer commented 5 years ago

"Direct JS debugging" sounds interesting...but I'm not entirely sure what that means and we didn't get into that at the conference.

aksonov commented 5 years ago

Yes, we definitely should try that, I see many benefits, like quicker startup time for android, smaller size, etc.

aksonov commented 5 years ago

I tried to do that and got red screen error that Proxy is not supported by Hermes (used by MobX 5.0+). So we have to downgrade to MobX4 or not to use Hermes.. Related tickets: https://github.com/facebook/hermes/issues/28 https://github.com/facebook/hermes/issues/33 https://github.com/mobxjs/mobx-react-lite/issues/184

southerneer commented 5 years ago

Oof, that sounds like a dealbreaker. I think the disadvantages of moving back to MobX 4 far outweigh the advantages of Hermes. There is some hope though. We may just need to wait.

bengtan commented 5 years ago

I guess we're gonna have to wait.