search

hippware / rn-chat

MIT License
5 stars 0 forks source link

Blocked user not removed from live location sharing #4021

Open mstidham opened 5 years ago

mstidham commented 5 years ago

Blocked user not removed from live location sharing

QA TEMPLATE Input
Device Type: iPhone 7 Plus
iOS: 12.4
tr Version: 4.20.1
Environment Prod
Codepush:
Internet Connection Type: WiFi
Users affected? Miranda
User handle: @miranda & @stidham
Bypass handle?:
Location access type? Always
Does this issue occur on other environments? ?
Time issue occurred (UTC)

Observed Result:

User @stidham (phone number was disconnected 2 days ago so I can no longer receive sms to log into that account) was sharing live location with user @miranda. @miranda blocked user @stidham but user remains on @miranda's header widget.

Expected Result:

If a user blocks another user they should only see that user in the blocked users list.

Steps to reproduce:

  1. Block a user that is sharing live location with you

Related Screenshots/Video Links:

mstidham commented 5 years ago

This remains an issue after the server fix.

Current situation:

  1. User "@firebasetest blocked user "@testytester"
  2. They were sharing live location
  3. Users avatars remain on the header widget

image

bengtan commented 5 years ago

@bernardd,

Can you please check/verify/confirm that the server handles blocking correctly re: live location shares?

Not necessarily implying that this ticket is a server side bug. Rather, just wanna establish what I should expect from the server before chasing it down on the client side.

bernardd commented 5 years ago

Looks like we missed adding it to the things cleared by a block. Fixing it now.

bernardd commented 5 years ago

Server side fix in https://github.com/hippware/wocky/pull/2789

bengtan commented 5 years ago

A server side fix has been deployed to Staging.

@mstidham: Please retest on Staging.

mstidham commented 5 years ago

Staging Version: 4.21.0 User @testally shared live location with user @miranda. @miranda blocked user @testally and then the app crashed on android (@testally account). Also @testally remained on the presence widget on @miranda's account after blocking the user.

Screenshot_20190822-112336_Samsung Experience Home

image

bengtan commented 5 years ago

Related? #3882

bengtan commented 5 years ago

Just talked to Bernard about this. Currently, what happens is as follows:

If A blocks B (and presuming that B was sharing live location to A), no (in-app) notifications are generated and sent to A's client nor B's client to notify that the live location share (from B to A) has been terminated.

Furthermore, even if such notifications were generated, the block (which removes all notifications related to the other party/user) might prevent it from having an effect anyway.

Need to think about this.

bengtan commented 5 years ago

Waiting for some server side changes:

location_share_end discussion hippware/wocky#2821

and then a subsequent client side change/fix.

bengtan commented 5 years ago

Note to self: Do #3882 and #4021 together.