[research] [ios] Possible "Dark Mode" issues

hippware / rn-chat

MIT License

5 stars 0 forks source link

[research] [ios] Possible "Dark Mode" issues #4252

Open mstidham opened 5 years ago

mstidham commented 5 years ago

[ ] Placeholder text is very faded in dark mode

Examples:

[ ] Text entered does not appear (Searches and titles etc.)

Examples:

[ ] Photo files names difficult to see

Example: IMG_45FDDE30F746-1

bengtan commented 5 years ago

I don't think we know enough about iOS dark mode to start thinking of solutions yet. Need some research first.

Also, we could read up on android dark mode too.

bengtan commented 5 years ago

RN 0.61.2 had some changes to supposedly better support dark mode. I don't know whether it also turned on some of this stuff or not.

bengtan commented 5 years ago

Random speculative thought:

Another thing that's different with iOS 4.28.0 is that it was built with Xcode 11. Maybe Xcode flips a switch somewhere which makes all these dark mode things happen.

bengtan commented 5 years ago

Did some reading.

Apps which link against the iOS 13.x SDK are configured, by default, to support light and dark mode. iOS 13 SDK comes with XCode 11. So ... when we built the app with XCode 11, it turned on dark mode by default.

However, since we're not ready for dark mode yet, we can opt out of dark mode via one of the following:

Build the app with Xcode 10, or
Opt out (section 'Opt Out of Dark Mode Entirely')

but in the longer term, I doubt we can withstand Apple's persuasion for us to support dark mode.

bengtan commented 5 years ago

Spun out ...

Temporarily opt out of iOS dark mode #4258

... so we can temporarily bypass these issues (for the short term).

But we need to continue the discussion about dark mode (ie. this ticket).

aksonov commented 5 years ago

Here is what I've found so far: As I see latest RN0.61.2 still doesn't include native Appearance module: https://github.com/facebook/react-native/commit/63fa3f21c5ab308def450bffb22054241a8842ef but there is pollyfil: https://github.com/expo/react-native-appearance

Latest react-navigation supports themes as well: https://reactnavigation.org/docs/en/themes.html

So we need to define 'dark' colours for every UI screen and possibly modify RNRF to support themes.

We just need to schedule it and set needed priority. Possibly we need to wait until Appearance will be included into RN release and some RN TextInput bugs will be fixed for dark theme (what Miranda found)