align connected and client in Transport. for #4288

hippware / rn-chat

MIT License

5 stars 0 forks source link

align connected and client in Transport. for #4288 #4845

Closed southerneer closed 4 years ago

southerneer commented 4 years ago

...based on my comment in the ticket: https://github.com/hippware/rn-chat/issues/4288#issuecomment-591627895. This is purely speculative since I can't think of a way to test this change with any precision. Logout/login didn't break. We'll probably just have to see if the same class of bugsnags pops up again.

bengtan commented 4 years ago

I looked at this PR. I'm neutral about it because I don't quite understand how it helps but I'm willing to have it be merged and we can try it out.

Alternatively, please look at some comments I posted at the corresponding ticket: https://github.com/hippware/rn-chat/issues/4288#issuecomment-591748968

aksonov commented 4 years ago

LGTM