search

hippware / rn-chat

MIT License
5 stars 0 forks source link

Onboarding screens should only appear once #4850

Open bengtan opened 4 years ago

bengtan commented 4 years ago

Due to discussions at https://github.com/hippware/rn-chat/issues/3740#issuecomment-590647323 and over a voice chat meeting ... it has been agreed that the onboarding screens should only appear once.

Ideally,

  1. It should only appear once per new user

but it might be more practical to do:

  1. It should only appear once per new install.

(I'll leave the discretion to the developer.)

southerneer commented 4 years ago

It has to be per install, because we can't turn on permissions for an existing user if they install the app on another device.

southerneer commented 4 years ago

Well, I guess we could still request the same permissions without the onboarding screens, but I think seeing onboarding on each new device is a normal experience for other apps so it shouldn't be disorienting for our users.

mstidham commented 4 years ago

I'm wondering if I should have waited to test this after this version but I deleted the app and reinstalled and got an app crash. I noted this on the bugsnag #4820

image

bengtan commented 4 years ago

@mstidham:

I'm guessing that the bugsnag/crash should be unrelated to this ticket, but if it's preventing you from QA-ing this ticket, then please wait until we look into it.

southerneer commented 4 years ago

@mstidham that test was with 4.41.0? What were the steps that led up to the crash? It sounds like this happened just after a fresh install...no other steps? I'm able to test this ticket successfully with the following steps...

  1. Install fresh 4.41.0
  2. login (bypass or regular)
  3. go through the onboarding screens
  4. logout
  5. login (same or different account)
  6. note that there's no need to go through the onboarding process again
southerneer commented 4 years ago

Also, I think the bug referenced in that screenshot is unrelated to this ticket. It looks like #4820 could use some more work.

mstidham commented 4 years ago

@southerneer Verified on Staging Version: 4.41.0