hippware / rn-chat

MIT License
5 stars 0 forks source link

Change notification text to "... is sharing their location with you" #4867

Closed bengtan closed 4 years ago

bengtan commented 4 years ago

I believe this text change applies to both the in-app notification item and the 'flashing-thing' that appears over the header widget (see rightmost screen in screenshot)

See below


From https://github.com/hippware/rn-chat/issues/4662#issuecomment-592656454:

If user Miranda has Sharing Location off with user Feb and user Feb turns on Location Sharing Always with Miranda the in-band notification says "Feb and you are sharing location". I think it should be "Feb is sharing their location with you".

This is after the users have connected and toggled the sharing location several times in different configurations.

image

mstidham commented 4 years ago

The notification on Updates (in app notification) is fine, this is only for the drop-down message (flashy-thing).

When 1 user shares location always to another user they receive the correct message. (shown in screenshot) image

mstidham commented 4 years ago

Verified on Staging Version: 4.40.2

mstidham commented 4 years ago

Verified on Prod Version: 4.40.2