search

hippware / rn-chat

MIT License
5 stars 0 forks source link

4851 motion modal 2 #4880

Closed southerneer closed 4 years ago

bengtan commented 4 years ago

Looks fine to me. No objections.

Uh ... there is a little bit of doubt in my mind ... Is this a complete alternative to #4854? It's so much more simpler than #4854 that I speculate it's only a subset of of #4854? (This doesn't change my opinion on the mergeability of this PR. I just had a doubt, that's all.)

aksonov commented 4 years ago

LGTM

southerneer commented 4 years ago

This isn't a complete alternative to PR #4854...this one just deals with issue #4851