Closed dependabot-preview[bot] closed 4 years ago
This is murky.
I didn't find a list of the changes. Not a good sign.
There might be API changes between 2.0.0-alpha.3 and 2.2.0 but I don't know.
It's not a direct dependency but a (supposed) dependency of react-navigation.
However, according to the documentation, enableScreens()
needs to be called before this component is used, implying this is an optional dependency.
We don't call enableScreens()
so maybe this component is not used anyway?
So ... I dunno. I'm inclined to ignore this upgrade but happy for someone more knowledgeable to give input.
I would hazard a guess that enableScreens()
is called in react-navigation
which would justify the peer dependency. But yeah, unless there's a peer dependency warning that we're using an outdated version of rn-screens it's probably safe to ignore updates. @aksonov has been working on a new rnrf version and may have some further input.
I did investigation here: react-navigation
doesn't call it, I've verified it by calling screensEnabled
flag. So I've just enabled it to optimize our app and upgraded to latest 2.3.0, seems to work fine. Maybe I can add it to RNRF core, but I'm not sure at this moment.
Happy to sit on this one and take our time thinking through the pros and cons.
Hm, I thought we could just publish it (yesterday) and check..
Bumps react-native-screens from 2.0.0-alpha.3 to 2.2.0.
Commits
04fdeb1
Bump version -> 2.2.0bef5803
Fix fragment added crash on Android native stack (#399)c4f31b0
Fix enter animation on Android native stack (#398)dc368b8
Use default insets for toolbar icons on Android to match iOS behavior (#396)26662ed
Reshuffle androidx dependencies not to require them being listed… (#397)46ca0a1
fix: remove background when stackPresentation is transparentModal (#386)8a335e1
Fix wrong import for react-navigation in v4 stack (#391)8160e26
Fix v5 native stack typings as of latest version (#392)e61bb8d
Add finishTransitioning event to native stack (#393)6068819
Bump version -> 2.1.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired)