search

hippware / rn-chat

MIT License
5 stars 0 forks source link

for #4888 #4906

Closed aksonov closed 4 years ago

aksonov commented 4 years ago

@southerneer Some minor things are left, like setup logger mock, tests and test live app, feel free to continue

bengtan commented 4 years ago

Suggestion: Can we postpone this merge until after this week's release please? Large changes should be given sufficient time for review and testing. Thanks.

aksonov commented 4 years ago

@bengtan I would like to finish and merge it PR before any other current PR will be merged to avoid re-doing it. It should not be big change actually, but just re-structure the things.

aksonov commented 4 years ago

@southerneer

Looks good so far. What do you mean by "test live app"?

I mean actual run of our app with this PR, I didn't have time to verify it yesterday

aksonov commented 4 years ago

Merging it after app testing and small test fix