search

hippware / rn-chat

MIT License
5 stars 0 forks source link

4850 onboard once #4907

Closed southerneer closed 4 years ago

southerneer commented 4 years ago

I'm sticking with the MST version of PermissionStore for this one. We can handle the conversion to vanilla mobx in a later PR for #4889. Same goes for maintaining the old persistence mechanism until we approach #4849 more holistically.

@aksonov if you're planning to have #4906 done your Thursday (and assuming you approve the changes in this PR), please hold off merging this one since it would cause some path conflicts. I'll make the necessary tweaks my Thursday morning before deploying to Staging.

southerneer commented 4 years ago

One more thing. I noticed that this problem (strangely) didn't come up in my testing of the changes on this PR so I didn't make any further tweaks to LocationStore. I do still think that we should refactor LocationStore eventually (maybe split out background functionality that doesn't manipulate or depend on other MST state), but that probably warrants more discussion.

bengtan commented 4 years ago

LGTM but not merging because ...

I'll make the necessary tweaks my Thursday morning before deploying to Staging.

... southerneer might re-roll it.

southerneer commented 4 years ago

rebased and force pushed. Merging.