search

hippware / rn-chat

MIT License
5 stars 0 forks source link

for #4905 #4912

Closed aksonov closed 4 years ago

southerneer commented 4 years ago

It seems like the test failure could be related to this change. @aksonov does this PR depend on a back-end change too?

aksonov commented 4 years ago

@southerneer Yes, looks like it is exact problem I described before - 'nearby end' event is not received:

    await bob.setLocation(differentLocation)
    await waitFor(() => !friend!.sharesLocation, 'end sharing location')
    await waitFor(() => !bob.profile!.sharesLocation, 'end sharing location')
southerneer commented 4 years ago

I codepushed this branch to StagingPavel and pinged Miranda to test. Phil is pushing back-end changes to Staging too.

bengtan commented 4 years ago

I re-ran the CircleCI tests and it passed.

There was a server deployment an hour-or-so after the most recent failed test so it seems that fixed up the back-end.

LGTM.

bengtan commented 4 years ago

Just discovered that QA has posted some feedback at #4905 so ... maybe this PR needs some more work?

aksonov commented 4 years ago

Great, it is very good to know that tests are passed, I'm going to merge it. More work could be done in other PR