Closed aksonov closed 4 years ago
@southerneer Yes, looks like it is exact problem I described before - 'nearby end' event is not received:
await bob.setLocation(differentLocation)
await waitFor(() => !friend!.sharesLocation, 'end sharing location')
await waitFor(() => !bob.profile!.sharesLocation, 'end sharing location')
I codepushed this branch to StagingPavel and pinged Miranda to test. Phil is pushing back-end changes to Staging too.
I re-ran the CircleCI tests and it passed.
There was a server deployment an hour-or-so after the most recent failed test so it seems that fixed up the back-end.
LGTM.
Just discovered that QA has posted some feedback at #4905 so ... maybe this PR needs some more work?
Great, it is very good to know that tests are passed, I'm going to merge it. More work could be done in other PR
It seems like the test failure could be related to this change. @aksonov does this PR depend on a back-end change too?