search

hippware / rn-chat

MIT License
5 stars 0 forks source link

4828 debug options screen #4921

Closed bengtan closed 4 years ago

bengtan commented 4 years ago

Hopefully it's self explanatory. Please see ticket #4828.

I do have one problem/question though.

In the mock https://zpl.io/a7Nz18p, there is a line/border under the title 'Debug Options' but it's not implemented in this PR. I'm not sure how best to do it. What's the best/common practice to achieve this? Any suggestions?

aksonov commented 4 years ago

LGTM. Border could be done with RNRF navbar styling: navigationBarStyle parameter for given scene, borderBottomWidth property (check Router.tsx global styling as example)

aksonov commented 4 years ago

LGTM