hippware / rn-chat

MIT License
5 stars 0 forks source link

Native and pod updates #4938

Closed bengtan closed 4 years ago

bengtan commented 4 years ago

Incorporates:

but then it complained about needing a newer version of the GoogleMaps pod so then:

(The reason for removing the Fabric key is that ... whilst looking at release notes for Firebase pods, I came across a mention that the Firebase iOS SDK wasn't using the Fabric key in plist files anymore. I don't think we're using it too? So I removed it.)

Anyway, here is the list of pod changes:

Installing Firebase 6.20.0 (was 6.13.0)
Installing FirebaseAnalytics 6.3.1 (was 6.1.6 and source changed to `https://cdn.cocoapods.org/` from `trunk`)
Installing FirebaseAnalyticsInterop 1.5.0 (was 1.4.0 and source changed to `https://cdn.cocoapods.org/` from `trunk`)
Installing FirebaseAuth 6.5.0 (was 6.4.0 and source changed to `https://cdn.cocoapods.org/` from `trunk`)
Installing FirebaseAuthInterop 1.1.0 (was 1.0.0 and source changed to `https://cdn.cocoapods.org/` from `trunk`)
Installing FirebaseCore 6.6.4 (was 6.4.0 and source changed to `https://cdn.cocoapods.org/` from `trunk`)
Installing FirebaseCoreDiagnostics 1.2.2 (was 1.1.2 and source changed to `https://cdn.cocoapods.org/` from `trunk`)
Installing FirebaseCoreDiagnosticsInterop 1.2.0 (was 1.1.0 and source changed to `https://cdn.cocoapods.org/` from `trunk`)
Installing FirebaseDynamicLinks 4.0.7 (was 4.0.5 and source changed to `https://cdn.cocoapods.org/` from `trunk`)
Installing FirebaseInstallations (1.1.0)
Installing GTMSessionFetcher 1.3.1 (was 1.3.0)
Installing GoogleAppMeasurement 6.3.1 (was 6.1.6 and source changed to `https://cdn.cocoapods.org/` from `trunk`)
Installing GoogleDataTransport 5.0.0 (was 3.2.0 and source changed to `https://cdn.cocoapods.org/` from `trunk`)
Installing GoogleDataTransportCCTSupport 2.0.0 (was 1.2.2 and source changed to `https://cdn.cocoapods.org/` from `trunk`)
Installing GoogleMaps 3.5.0 (was 3.2.0 and source changed to `https://cdn.cocoapods.org/` from `trunk`)
Installing GoogleUtilities 6.5.2 (was 6.3.2)
Installing PromisesObjC (1.2.8)
Installing react-native-google-maps 0.27.0 (was 0.26.1)
Installing react-native-maps 0.27.0 (was 0.26.1)
Removing FirebaseInstanceID

I tried to find release notes for all these changes and it was very tedious so I gave up (for now). What do you guys think? Should we look at the changelogs before merging this?

I ran the app in the iOS simulator and it seemed okay.

bengtan commented 4 years ago

I ran the app in the iOS simulator and it seemed okay.

I take this back. Something's broken.

bengtan commented 4 years ago

I'm having trouble testing this PR.

When I try to log in using firebase on iOS simulator, it fails with 'Error verifying phone number ...' and I see this in the js console:

LOG  [MST] /firebaseStore/verifyPhone args: ["+61404378363"]
LOG  TRACK sms_confirmation_try undefined
LOG  Push Notification: {"alert": undefined, "badge": undefined, "data": {"com.google.firebase.auth": {"warning": "This fake notification should be forwarded to Firebase Auth."}, "notificationId": "ED3CC66F-85DE-47A7-843B-236BEEA3BB2C", "remote": true}, "finish": [Function finish], "foreground": true, "message": undefined, "sound": undefined, "userInteraction": false}
LOG  TRACK push_notification_received {"notification": {"alert": undefined, "badge": undefined, "data": {"com.google.firebase.auth": [Object], "notificationId": "ED3CC66F-85DE-47A7-843B-236BEEA3BB2C", "remote": true}, "finish": [Function finish], "foreground": true, "message": undefined, "sound": undefined, "userInteraction": false}}
LOG  TRACK sms_confirmation_fail {"error": [Error: {"error":{"code":403,"message":"Requests from this ios client application <empty> are blocked.","errors":[{"message":"Requests from this ios client application <empty> are blocked.","domain":"global","reason":"forbidden"}],"status":"PERMISSION_DENIED"}}], "phone": "+61404378363"}

AFAICT, this also happens on master code. It may just be something wrong with the iOS simulator but I don't know yet. However, it's preventing me from testing this PR.

bengtan commented 4 years ago

Okay, tested on a real device (under XCode debug). Seems okay. Smoke test passed.

aksonov commented 4 years ago

LGTM