Closed bengtan closed 4 years ago
I ran the app in the iOS simulator and it seemed okay.
I take this back. Something's broken.
I'm having trouble testing this PR.
When I try to log in using firebase on iOS simulator, it fails with 'Error verifying phone number ...' and I see this in the js console:
LOG [MST] /firebaseStore/verifyPhone args: ["+61404378363"]
LOG TRACK sms_confirmation_try undefined
LOG Push Notification: {"alert": undefined, "badge": undefined, "data": {"com.google.firebase.auth": {"warning": "This fake notification should be forwarded to Firebase Auth."}, "notificationId": "ED3CC66F-85DE-47A7-843B-236BEEA3BB2C", "remote": true}, "finish": [Function finish], "foreground": true, "message": undefined, "sound": undefined, "userInteraction": false}
LOG TRACK push_notification_received {"notification": {"alert": undefined, "badge": undefined, "data": {"com.google.firebase.auth": [Object], "notificationId": "ED3CC66F-85DE-47A7-843B-236BEEA3BB2C", "remote": true}, "finish": [Function finish], "foreground": true, "message": undefined, "sound": undefined, "userInteraction": false}}
LOG TRACK sms_confirmation_fail {"error": [Error: {"error":{"code":403,"message":"Requests from this ios client application <empty> are blocked.","errors":[{"message":"Requests from this ios client application <empty> are blocked.","domain":"global","reason":"forbidden"}],"status":"PERMISSION_DENIED"}}], "phone": "+61404378363"}
AFAICT, this also happens on master
code. It may just be something wrong with the iOS simulator but I don't know yet. However, it's preventing me from testing this PR.
Okay, tested on a real device (under XCode debug). Seems okay. Smoke test passed.
LGTM
Incorporates:
but then it complained about needing a newer version of the GoogleMaps pod so then:
(The reason for removing the Fabric key is that ... whilst looking at release notes for Firebase pods, I came across a mention that the Firebase iOS SDK wasn't using the Fabric key in plist files anymore. I don't think we're using it too? So I removed it.)
Anyway, here is the list of pod changes:
I tried to find release notes for all these changes and it was very tedious so I gave up (for now). What do you guys think? Should we look at the changelogs before merging this?
I ran the app in the iOS simulator and it seemed okay.