search

hippware / rn-chat

MIT License
5 stars 0 forks source link

Review 'allow newly created bots on BotDetails' #945

Closed bengtan closed 7 years ago

bengtan commented 7 years ago

Quoting @southerneer:

The second one I found smoke testing -- newly created bots would bonk BotDetails. I commented out the offending line and it works now, but I'm not entirely sure I understand all the possible implications of the change. Will want @aksonov to review.

https://github.com/hippware/rn-chat/commit/783fadd0c1c64e745cafce349ff1d932e72916db

bengtan commented 7 years ago

Is this related to Bug: Bot Edit: Unable to edit bot and change privacy settings #930? The symptoms sound potentially similar. Maybe it's the same cause.

If it is the same cause, we should (undo this change and) fix #930 properly.

bengtan commented 7 years ago

Came across this whilst looking at something else.

This is really old and I can't even remember the details anymore.

Closing as obsolete.