Review and improve performance of geofence algorithm

hippware / wocky

Server side (Erlang/Elixir) software

13 stars 3 forks source link

Review and improve performance of geofence algorithm #1992

Closed toland closed 5 years ago

toland commented 5 years ago

Ideas for low-hanging fruit:

~Use LB session affinity so the client will upload location to a single pod~
~Load all bot events in one query (eliminate N+1)~
Use GIS index to determine bot entries
~Queue location updates and have one geofence process per user~

This work needs to land on master and next.

toland commented 5 years ago

Use LB session affinity so the client will upload location to a single pod

We can't use session affinity with our current LB setup. We can look into this again after we purge XMPP.

toland commented 5 years ago

Load all bot events in one query (eliminate N+1)

This was low-hanging fruit. There are PRs open for master (#1999) and next (#2000).

toland commented 5 years ago

The last two items on this list are large changes. I am going to open new tickets to track them.

toland commented 5 years ago

Spun out into #2029 and #2030.

bengtan commented 5 years ago

I think this can be closed. Any follow-ups can be a new ticket.

@toland: Or do you want to move this ticket back to Discussion and follow up in the future?

(Just trying to declutter)

toland commented 5 years ago

I think we should move it to Discussion and follow up later. Having made these changes, we want to know what impact they have had on geofence processing, and I think we need a ticket to remind us to follow up. We could create another ticket and close this one, but I'm not sure that buys us anything.

toland commented 5 years ago

I am going to go ahead and close this. The changes have been out there for a while and geofence processing is running fine. We don't really have a good set of "before" metrics, so generating "after" metrics will be helpful going forward, but won't help us determine the utility of the changes we already made.