search

hippware / wocky

Server side (Erlang/Elixir) software
13 stars 3 forks source link

Test/review account deletion #2804

Closed bengtan closed 5 years ago

bengtan commented 5 years ago

Please test/review account deletion to verify that it works as expected. I have no reason to suspect breakage but I'm just being careful because we want to use this capability on Prod (and it involves loss of data).

Please test/review on Testing/Staging first.

bernardd commented 5 years ago

The code all looks in order and is covered by tests.

(and it involves loss of data).

Well yes, but that would be the point :)

bengtan commented 5 years ago

@mstidham has two test accounts on Prod/us1 that can be deleted. They are:

LaCroix +16505550005 firebasetest +16505550006

Can you delete one of them ... and also check whether it worked as expected?

bernardd commented 5 years ago

So neither of those successfully delete using the standard API because somehow the user has already been removed from Firebase. That causes the Firebase removal step to fail. Any idea why they wouldn't be there? I can manually clean them up, but I'd like to know how they came to not be in firebase in the first place.

bengtan commented 5 years ago

It's a bit of a story.

Those accounts were created using firebase test numbers, which are special phone numbers with hardcoded 6-digit codes (that we choose).

Last week, Miranda needed new firebase test numbers so she could test account creation/onboarding.

However, Google only allows us to create a maximum of 10 numbers, and we were near, or had hit, the limit.

So, in order to create a couple of new numbers, I deleted some no-longer-needed firebase test numbers.

So, for these two accounts, I had removed the firebase test numbers. I didn't realise it would trip over firebase/firebase API.

bernardd commented 5 years ago

It didn't trip over the API, it tripped over our app which assumes people aren't going to be manually deleting third party data we rely on.

So do you want me to manually go ahead and delete those two accounts? Any others I should know about that are now out of sync that also need tidying up?

bengtan commented 5 years ago

So do you want me to manually go ahead and delete those two accounts?

Yes, please. Treat it as a trial run.

Any others I should know about that are now out of sync that also need tidying up?

No others. Only those two.

bengtan commented 5 years ago

bengtan to progress this ticket:

bengtan commented 5 years ago

QA has been deleting accounts on Prod/us1 (with a special debug build) and all seems fine. Closing.