Clipboard Gadget using edit-paste icon

[enigma9o7]

There is an action icon called edit-paste that is used in some applications to paste, it matches similar icons like copy/etc.

The clipboard gadget is using this icon. It should use clipboard. This causes problems because action icons are handled differently than status icons due to scaling issues. edit-paste is an action icon (not a status/panel icon).

Anyways please change it to use "clipboard" icon.

[thewaiter]

Not possible There is no clipboard icon in Linux naming schema: https://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html

[enigma9o7]

I think you are confused. What I suggested is totally possible and simple.

Icons are provided by theme. When an app (or moksha module) installs itself, it can place its default clipboard.png icon in hicolor or xdg-icons. When an icon theme has the icon already, it will be used. Most icon sets already include this icon, but for those that don't, it reverts to hicolor first, then pixmaps. This is xdg spec.

Don't use the same name as any of those on that link you described or it may conflict or cause problems with what's supposed to use those icons.

[thewaiter]

Need to check then. Anyway, I have not seen any issues related to the current icon

[enigma9o7]

The problem is that it's using edit-paste. That is already predefined for something else. Its even in the link you pasted:

[thewaiter]

Hmm, maybe I am wrong, but tried several known icons themes like Gnome, Adwaita, Faba, Obsidian and "clipboard" icon is not included.

[enigma9o7]

Most icon themes are missing lots of system tray and other application icons. Applications are supposed to install those themselves into hicolor theme, or pixmaps folder. But if an icon theme wants to override those installed by the app, it can. If you look in status folder of viceversa icons you'll see I got a clipboard icon and about five links to it from other apps names, getting tray/status/panel icons complete and matching was one of the things I've been trying to work on..

I dont think gnome or adwaita include tray icons for anything.

But it doesn't matter. As long as installing the module installs a default icon, if the user decides to use gnome or adwaita or something without a clipboard icon, then it'll use the default, so don't matter if custom icon theme has it or not. This is xdg spec.

[thewaiter]

This is the command I use for define gadget icon: e_icon_fdo_icon_set(o, "edit-paste");

I always need to put there a general/universal icon name which is included in all themes. Edit-paste completelly fullfil this need although it is an action icon. I see no other universal way to make it better. Moreover Clipboard module is not systray app but pure Moksha module. Sorry

[thewaiter]

The only what I can do is this: if (!e_icon_fdo_icon_set(o, "clipboard")) e_icon_fdo_icon_set(o, "edit-paste");

if clipboard.png or clipboard.svg is not found, edit-paste will be used instead.

[enigma9o7]

That would work, but that is unneeded. This is already automatic if following xdg-spec.

When installing clipboard module, it should install its own icon into hicolor or pixmaps. If the problem is that it is not including icon during installation or as dependency whatever, then update the package. But no need to hack workaround in for something, better to fix the packaging problem.

There is no situation where it should be using edit-paste. That icon is for paste action.

[thewaiter]

OK, commited to moksha code. git pull and install https://github.com/JeffHoogland/moksha/commit/88339b92eb19e502cb9896ced1bb1eebe795ccc8

[thewaiter]

Join discord again. It is weird chatting here

[enigma9o7]

Join discord again. It is weird chatting here

This is an issue tracker, for reporting issues. Discord is for chatting, so that makes sense.

Anyway me joining discord is not related to this issue at all so will not discuss that here.