search

hipspy / hips

Python library to handle HiPS
https://hips.readthedocs.io
12 stars 16 forks source link

Reformat docstring for create_from_dict class method #102

Closed adl1995 closed 7 years ago

adl1995 commented 7 years ago

As @cdeil mentioned in #100: https://github.com/hipspy/hips/pull/100#issuecomment-319957989, I have made small improvements to the docstring, apart from some other changes.

adl1995 commented 7 years ago

@cdeil - I'm not sure why the test fails at this line:

skycoord = SkyCoord.from_name(params.pop('target'), frame=params['coordsys'])

In this case, target = 'crab', but the test does pass locally.

cdeil commented 7 years ago

Looks good to me. Merging now.

Concerning the target = 'crab' test fail: let's just merge everything in and then see if there's still a test fail locally or on travis-ci (and if so, fix it in a follow-up PR).