search

hipspy / hips

Python library to handle HiPS
https://hips.readthedocs.io
13 stars 16 forks source link

Update astropy-helpers to v3.2.1 #143

Closed bsipocz closed 1 year ago

bsipocz commented 5 years ago

This is an automated update of the astropy-helpers submodule to v3.2.1. This includes both the update of the astropy-helpers sub-module, and the ah_bootstrap.py file, if needed. Please note that since v3.2, sphinx-astropy needs to be explicitely listed as a dependency for building the documentation. A full list of changes can be found in the changelog.

We've also noticed that you likely used the astropy package template in the past for your package and that your conftest.py file is now out of date and imports pytest plugins from astropy:

from astropy.tests.pytest_plugins import *

This astropy sub-package has been removed, so your tests will likely be failing now that astropy v3.2 has been released. This PR therefore fixes this import by checking the astropy version and adjusting the import as needed.

We also wanted to let you know that we have made new releases of the astropy package-template. You can find the latest cookiecutter template here or if you prefer you can find a rendered version of the template here.

This is intended to be helpful, but if you would prefer to manage these updates yourself, or if you notice any issues with this automated update, please let @bsipocz or @astrofrog know!

Similarly to the core package, the v3.0+ releases of astropy-helpers require Python 3.5+. We will open automated update PRs with astropy-helpers v3.2.x only for packages that specifically opt in for it when they start supporting Python 3.5+ only. Please let @bsipocz or @astrofrog know or add your package to the list in https://github.com/astropy/astropy-procedures/blob/master/update-packages/helpers_3.py

cdeil commented 5 years ago

@bsipocz - There's one build fail: https://travis-ci.org/hipspy/hips/jobs/550085876

Not sure if it's present already in master.

Can you fix and merge this in?

bsipocz commented 5 years ago

That must be around in master, too, will push a fix, but I don't have access to merge.

cdeil commented 5 years ago

What is this? https://ci.appveyor.com/project/cdeil/hips-19275o3fsp6drby/builds/27936153

What's the common / recommended setup for Windows for affiliated packages these days? Appveyor or move the build somewhere else?

bsipocz commented 5 years ago

We have a fix in ci-helpers that will make appveyor work again, but otherwise yes, the recommendation is to switch to travis or azure, and project wide we stop supporting appveyor at all.

bsipocz commented 5 years ago

working examples for the travis config are e.g. in photutils/astropy core/etc.

My recommendation would be to switch on stages, and have the windows build the last stage to run it as little as possible, as it's pretty slow.