Closed adl1995 closed 7 years ago
@adl1995 - Can you please wrap up this pull request?
Once you've implemented comments, always leave a comment asking me to have another look, or if you don't know how to address one of my comments, leave a comment asking for clarification. If you just push new commits, I usually won't look at a PR until you ping me.
In this case: you're still not taking the OrderedDict
as input in __init__
, like I suggested in an inline comment above. Can you please change this? Is it clear what to do?
@cdeil I just made another commit. Let me know if the __init__
method is being called in the correct manner now.
@adl1995 - I've just now pushed a commit to your branch for this PR: 3f9faed233a0d10cc771532d09f79eff7d279450
Some changes:
HipsDesription.read
method can be tested (and adding the common Astropy boilerplate of setup_package.py
that makes sure the data file gets installed into site-packages with the package, and using an Astropy helper function to create the filename relative to the text module)I think this is ready to be merged, but I'll wait for travis-ci to run or comments until tomorrow.
@adl1995 - Thanks!
This commits adds a class named HipsDescription which provides methods for parsing the HiPS properties. It parses the given string and returns an object of OrderedDict. Additional getter methods are also included. For the test cases, a sample properties file was obtained from http://alasky.unistra.fr/DSS/DSSColor/properties