search

hipspy / hips

Python library to handle HiPS
https://hips.readthedocs.io
13 stars 16 forks source link

Add WCS property in HipsTile class #37

Closed adl1995 closed 7 years ago

adl1995 commented 7 years ago

I added a WCS property in HipsTile class. As drawing is going to be a major part of this library, I think this is a useful addition to the class.

cdeil commented 7 years ago

@adl1995 - I don't think this will work. Currently the FITS headers of HiPS tiles in FITS format don't contain a valid WCS that would be useful for drawing. See #17.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 80.252% when pulling c5cd3e6f0b217b3b48631b4e2d446ddac33c262f on adl1995:tiles.wcs into 32db7fbedfebbc1a77028c35f80b9fb45a483cc1 on hipspy:master.

adl1995 commented 7 years ago

But, wouldn't we still require this later on?

cdeil commented 7 years ago

@adl1995 - Not necessarily, we can draw the tile without having a WCS for the tile itself.

It would be nice to have though, since if we have a WCS for the tile we can just call reproject as an alternative precise drawing method, as mentioned in #17.

There's nothing you can do here for now, I'd suggest to just close this PR without merging. Maybe in the future, Thomas will provide code to compute the tile WCS, or maybe we won't go that way.