search

hipspy / hips

Python library to handle HiPS
https://hips.readthedocs.io
13 stars 16 forks source link

Rename data to raw_data #38

Closed adl1995 closed 7 years ago

adl1995 commented 7 years ago

This PR addresses issue #36.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 80.169% when pulling 78d14ce957576b37c4465035515d2762bbf16b42 on adl1995:tiles.formats into 32db7fbedfebbc1a77028c35f80b9fb45a483cc1 on hipspy:master.

cdeil commented 7 years ago

@adl1995 - As-is, this isn't really useful. You're just doing a rename data -> raw_data, and then adding a property data that aliases raw_data.

My suggestion in #36 was to add a new property called raw_data that stores the bytes from tile files, i.e. something like:

self.raw_data = BytesIO(urllib.request.urlopen(url).read())

and to make a property @data that extracts the Numpy array from the bytes.

@adl1995 - If it's still not clear how this should work, please put it on the agenda for the call today and I'll explain.

cdeil commented 7 years ago

@adl1995 - I'm closing this old PR.

As I said in my last comment and #36 , it doesn't properly implement what we need, there's already a merge conflict and there will be more merge conflicts after #46 .

My suggestion is to start a new branch / PR next week after #46 is in.