hipspy / hips

Python library to handle HiPS
https://hips.readthedocs.io
13 stars 16 forks source link

Set up coveralls #4

Closed cdeil closed 7 years ago

cdeil commented 7 years ago

Reminder issue for myself to set up coveralls for this package (after travis-ci is set up, the coverage report is computed on travis-ci and then sent to coveralls).

cdeil commented 7 years ago

Note to self: I've activated coveralls for this repo and added a badge to the README. Coverage reports should appear here: https://coveralls.io/r/hipspy/hips as soon as the coverage build on travis-ci works. It's currently failing as mentioned in #6 .

cdeil commented 7 years ago

This is done.

For now, we have the coveralls service commenting on our pull requests, stating how coverage changes. With most other repos I have this turned off because it can be annoying. But here where we start out with no code (100% coverage) I guess it can be useful, to always get a link to code being introduced by a PR that's not covered by tests. So I'll leave that notification setting on for now. But @adl1995 @tboch - if you don't like it, let me know and I'll turn coveralls comments off.

Closing this issue now.