Open cdeil opened 7 years ago
I've added some info in this docstring: https://github.com/hipspy/hips/commit/9b52a7a7eac2b8092ab568dec8e8a13b8bb0a877
I'm keeping this issue open and assigning to myself, the remaining task is to explain this clearly in the high-level docs.
I'm splitting out one point of discussion from #30 : we should have a strategy how to handle different dtypes (int, float) and when conversions occur. This is a reminder issue for @adl1995 to write a small docs page describing the behaviour and to add tests asserting it.
At the moment it looks like the scikit-image transform we call always outputs floats, it can't output ints directly (this kinda makes sense, interpolation methods usually need floats as far as I know).
So for now, we're calling with
preserve_range=True
, which gives backfloat64
with roughly the same values as the inputint16
image in our FITS test case.There's several things to discuss / decide here, namely whether to convert to
float32
by default to save space and avoid thefloat64
, whether to provide options inhips
to convert back toint
images, or whether to only document to users how to do that, ...